oxsean commented on code in PR #15448:
URL: https://github.com/apache/dubbo/pull/15448#discussion_r2140640224


##########
dubbo-common/src/main/java/org/apache/dubbo/common/logger/LoggerFactory.java:
##########
@@ -193,6 +193,32 @@ public static ErrorTypeAwareLogger 
getErrorTypeAwareLogger(String key) {
                 ERROR_TYPE_AWARE_LOGGERS, key, k -> new 
FailsafeErrorTypeAwareLogger(loggerAdapter.getLogger(k)));
     }
 
+    /**
+     * Get error type aware logger by FQCN and Class object.
+     *
+     * @param fqcn the full qualified class name of caller
+     * @param key the returned logger will be named after clazz
+     * @return error type aware logger
+     */
+    public static ErrorTypeAwareLogger getErrorTypeAwareLogger(String fqcn, 
Class<?> key) {
+        return ConcurrentHashMapUtils.computeIfAbsent(
+                ERROR_TYPE_AWARE_LOGGERS,
+                key.getName(),

Review Comment:
   key.getName() -> Pair.of(key.getName(), fqcn)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to