vio-lin commented on PR #15444:
URL: https://github.com/apache/dubbo/pull/15444#issuecomment-2965300560
> > i think the simplest way might be:
> >
> > 1. move `markedClass` from method registerInterface into the fields of
SerializeSecurityConfigurator for checking whether the interface has been
checked or not, using HashSet is enough since registerInterface is synchronized
method.
> > 2. add such checking codes to the beginning of method registerInterface:
> >
> > ```
> > if (!checkClass(clazz)) {
> > return;
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > 3. change the result type of checkClass method and remove markedClass
from it's input params
> >
> > ```
> > private boolean checkClass(Class<?> clazz) {
> > if (clazz == null) {
> > return false;
> > }
> >
> > if (!markedClass.add(clazz)) {
> > return false;
> > }
> > // return true at follow codes.
> > ```
>
> @vio-lin would you like testing this plan and feedback what's the
different?
wait for moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
