oxsean commented on code in PR #15466:
URL: https://github.com/apache/dubbo/pull/15466#discussion_r2153533157
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/Http1SseServerChannelObserver.java:
##########
@@ -35,6 +35,12 @@ public void setResponseEncoder(HttpMessageEncoder
responseEncoder) {
super.setResponseEncoder(new ServerSentEventEncoder(responseEncoder));
}
+ @Override
+ protected void doOnCompleted(Throwable throwable) {
+ sendMetadata(encodeHttpMetadata(true));
Review Comment:
Your previous approach was correct — a check is needed here to avoid an
unnesssory encoding of Metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
