zrlw commented on code in PR #15518:
URL: https://github.com/apache/dubbo/pull/15518#discussion_r2182360076
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TriHttp2RemoteFlowController.java:
##########
@@ -778,11 +778,7 @@ private void
checkConnectionThenStreamWritabilityChanged(FlowState state) throws
} else if (isWritable(state) != state.markedWritability()) {
notifyWritabilityChanged(state);
} else if (isOverFlowControl()) {
- throw streamError(
- state.stream().id(),
- FLOW_CONTROL_ERROR,
- "TotalPendingBytes size overflow for stream: %d",
- state.stream().id());
+ logger.warn("TotalPendingBytes size overflow for stream: " +
state.stream().id());
Review Comment:
at server side, it should pause or slow down sending when overflow occurs,
but it should not cancel or throw exception to break down the sending process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
