1kasa commented on code in PR #2934:
URL: https://github.com/apache/dubbo-go/pull/2934#discussion_r2199938077
##########
compat.go:
##########
@@ -395,6 +396,65 @@ func compatMetricPrometheusConfig(c
*global.PrometheusConfig) *config.Prometheus
}
}
+func compatReferences(c map[string]*global.ReferenceConfig)
map[string]*config.ReferenceConfig {
Review Comment:
Because my PR (https://github.com/apache/dubbo-go/pull/2941) needs this
part of code. If it is missing, CI will fail. So I decided to close this PR and
implement it in the next PR (https://github.com/apache/dubbo-go/pull/2941) . I
will modify the content of your comment in this
PR(https://github.com/apache/dubbo-go/pull/2941) ，And after all, these two PRs
are for the same problem, so I decided to close it later.
##########
compat.go:
##########
@@ -395,6 +396,65 @@ func compatMetricPrometheusConfig(c
*global.PrometheusConfig) *config.Prometheus
}
}
+func compatReferences(c map[string]*global.ReferenceConfig)
map[string]*config.ReferenceConfig {
+ if c == nil {
+ return nil
+ }
+ refs := make(map[string]*config.ReferenceConfig, len(c))
+ for name, ref := range c {
+ refs[name] = &config.ReferenceConfig{
+ InterfaceName: ref.InterfaceName,
+ Check: ref.Check,
+ URL: ref.URL,
+ Filter: ref.Filter,
+ Protocol: ref.Protocol,
+ RegistryIDs: ref.RegistryIDs,
+ Cluster: ref.Cluster,
+ Loadbalance: ref.Loadbalance,
+ Retries: ref.Retries,
+ Group: ref.Group,
+ Version: ref.Version,
+ Serialization: ref.Serialization,
+ ProvidedBy: ref.ProvidedBy,
+ Methods:
compatMethodsConfig(ref.MethodsConfig),
+ Async: ref.Async,
+ Params: ref.Params,
+ Generic: ref.Generic,
+ Sticky: ref.Sticky,
+ RequestTimeout: ref.RequestTimeout,
+ ForceTag: ref.ForceTag,
+ TracingKey: ref.TracingKey,
+ MeshProviderPort: ref.MeshProviderPort,
+ }
+ }
+ return refs
+}
+
+func compatMethodsConfig(methods []*global.MethodConfig)
[]*config.MethodConfig {
+ if methods == nil {
Review Comment:
Because my PR (https://github.com/apache/dubbo-go/pull/2941) needs this part
of code. If it is missing, CI will fail. So I decided to close this PR and
implement it in the next PR (https://github.com/apache/dubbo-go/pull/2941) . I
will modify the content of your comment in this
PR(https://github.com/apache/dubbo-go/pull/2941) ，And after all, these two PRs
are for the same problem, so I decided to close it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
