Similarityoung commented on code in PR #732:
URL: https://github.com/apache/dubbo-go-pixiu/pull/732#discussion_r2281290550
##########
pkg/common/constant/key.go:
##########
@@ -50,6 +50,7 @@ const (
HTTPTrafficFilter = "dgp.filter.http.traffic"
HTTPPrometheusMetricFilter = "dgp.filter.http.prometheusmetric"
HTTPFailInjectFilter = "dgp.filter.http.faultinjection"
+ HTTPAuthOPAFilter = "dgp.filter.http.opa"
Review Comment:
OPA 的确是个通用引擎。但是我看 filter 目录现在的结构像是按功能(比如auth和authority)划分的,而这段代码的功能也确实是授权。
那是不是把它放到授权目录里,来保持项目结构的一致性会更好?还是说独立创建一个 opa 后续再做功能拓展。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]