AlexStocks commented on code in PR #2992:
URL: https://github.com/apache/dubbo-go/pull/2992#discussion_r2305871207
##########
loader.go:
##########
@@ -64,9 +68,73 @@ func Load(opts ...LoaderConfOption) error {
}
instance := &Instance{insOpts: instanceOptions}
+ // start the file watcher
+ once.Do(func() {
+ go watch(conf)
Review Comment:
1 把 go 换成 https://github.com/dubbogo/gost/blob/master/runtime/goroutine.go
里面的 GoSafely
2 这里的 go 为何没有退出控制机制？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
