AlexStocks commented on code in PR #3021:
URL: https://github.com/apache/dubbo-go/pull/3021#discussion_r2345875430
##########
registry/directory/directory.go:
##########
@@ -367,7 +367,13 @@ func (dir *RegistryDirectory) toGroupInvokers()
[]protocolbase.Invoker {
clusterKey :=
dir.GetURL().SubURL.GetParam(constant.ClusterKey, constant.DefaultCluster)
cluster, err := extension.GetCluster(clusterKey)
if err != nil {
- panic(err)
+ logger.Errorf("directory get cluster %s error,
error message is %s, will skip this group",
Review Comment:
"error message is %s" 改为 " error message is %w"，酱紫后面参数只用写 err 即可
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
