robocanic commented on code in PR #1332: URL: https://github.com/apache/dubbo-admin/pull/1332#discussion_r2383975405
########## pkg/core/bootstrap/init.go: ########## @@ -15,8 +15,14 @@ * limitations under the License. */ -package memory +package bootstrap -import _ "k8s.io/client-go/tools/cache" - -// TODO implement memory resource store, refer to client-go cache.Store +import ( + _ "github.com/apache/dubbo-admin/pkg/console" + _ "github.com/apache/dubbo-admin/pkg/core/discovery" + _ "github.com/apache/dubbo-admin/pkg/core/engine" + _ "github.com/apache/dubbo-admin/pkg/core/events" + _ "github.com/apache/dubbo-admin/pkg/core/manager" + _ "github.com/apache/dubbo-admin/pkg/core/store" + _ "github.com/apache/dubbo-admin/pkg/store/memory" +) Review Comment: no need to comment, it used to import pkg so that `init` func works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
