fantiq commented on code in PR #15639:
URL: https://github.com/apache/dubbo/pull/15639#discussion_r2387325743
##########
dubbo-configcenter/dubbo-configcenter-zookeeper/src/main/java/org/apache/dubbo/configcenter/support/zookeeper/ZookeeperDynamicConfiguration.java:
##########
@@ -68,23 +67,6 @@ public class ZookeeperDynamicConfiguration extends
TreePathDynamicConfiguration
new AbortPolicyWithReport(threadName, url));
zkClient = zookeeperClientManager.connect(url);
- boolean isConnected = zkClient.isConnected();
Review Comment:
if the check = false and connection is unavailable, the client will add to
cache, but will not assign the `externalConfiguration` and
`appExternalConfiguration`.
Is it necessary to assign the `externalConfiguration` and
`appExternalConfiguration` when connection recovery?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
