HsDodo opened a new pull request, #3053:
URL: https://github.com/apache/dubbo-go/pull/3053
## Potential Panic Risk
The main risk occurs in the cleanIfRequired function at this line:
```go
elapsed := now.Sub(*weightedRoundRobin.lastUpdate).Nanoseconds()
```
## Risk Analysis
1. **Nil Pointer Dereference**:
- When a new weightedRoundRobin is created via `LoadOrStore`, the
lastUpdate field might not always be properly initialized
- If weightedRoundRobin.lastUpdate is `nil`, dereferencing it with
`*weightedRoundRobin.lastUpdate` will cause a panic
2. **Race Condition**:
- Multiple goroutines might access the same weightedRoundRobin instance
- One goroutine might be in the process of initializing the lastUpdate
field while another tries to access it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
