KamToHung commented on code in PR #3054:
URL: https://github.com/apache/dubbo-go/pull/3054#discussion_r2441533315


##########
registry/protocol/protocol.go:
##########
@@ -269,7 +291,34 @@ func registerServiceMap(invoker base.Invoker) error {
        // such as 
dubbo://:20000/org.apache.dubbo.UserProvider?bean.name=UserProvider&cluster=failfast...
        id := providerUrl.GetParam(constant.BeanNameKey, "")
 
-       serviceConfig := config.GetProviderConfig().Services[id]
+       if providerConfRaw, ok := 
providerUrl.GetAttribute(constant.ProviderConfigPrefix); ok {

Review Comment:
   This part of the logic if it is better to first check the config and then 
the global



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to