AlexStocks commented on code in PR #3034:
URL: https://github.com/apache/dubbo-go/pull/3034#discussion_r2443738370
##########
common/extension/registry_directory.go:
##########
@@ -43,22 +43,22 @@ func SetDirectory(key string, v registryDirectory) {
}
// GetDefaultRegistryDirectory finds the registryDirectory with url and
registry
-func GetDefaultRegistryDirectory(config *common.URL, registry
registry.Registry) (directory.Directory, error) {
+func GetDefaultRegistryDirectory(url *common.URL, registry registry.Registry)
(directory.Directory, error) {
Review Comment:
这块变量名称,可能是按照 dubbo 写的,你把 dubbo 相关的代码找找看下。感觉没必要改。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]