Alanxtl commented on code in PR #3059:
URL: https://github.com/apache/dubbo-go/pull/3059#discussion_r2450191466
##########
config_center/nacos/impl.go:
##########
@@ -168,7 +168,12 @@ func (n *nacosDynamicConfiguration) GetRule(key string,
opts ...config_center.Op
Group: resolvedGroup,
})
if err != nil {
- return "", perrors.WithStack(err)
+ if strings.Contains(err.Error(), "config data not exist") {
+ logger.Warnf("query rule fail, key=%s, group=%s,
err=%v", key, resolvedGroup, err)
+ return "", nil
Review Comment:
okey, 在上面加一下注释 说明一下这个判断两个分支分别代表什么情况
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
