Alanxtl commented on code in PR #3046:
URL: https://github.com/apache/dubbo-go/pull/3046#discussion_r2510086046
##########
registry/etcdv3/service_discovery_test.go:
##########
@@ -51,6 +52,7 @@ func TestEtcdV3ServiceDiscoveryGetDefaultPageSize(t
*testing.T) {
}
func TestFunction(t *testing.T) {
+ t.Skip("Skipping test: CI environment does not support etcd dependency")
Review Comment:
那这个 `gost` 更新应该是不合理的，这个依赖的链条是`gost` -> `etcd/clientv3` ->
`grpc`，现在grpc弃用了`grpc.WithBlock()` 而 `etcd/clientv3` 并没有弃用
(关于他们弃不弃用我[问了](https://github.com/etcd-io/etcd/issues/20910)etcd他们)，我们 `gost`
依赖的是 `etcd/clientv3`，却把 `grpc` 的方法删了，导致 `etcd/clientv3` 的行为没有达到预期
现在需要确定一个事情就就是：原来的报错是不是预期行为，这里看起来似乎就是要把它block住，如果是预期行为 那么这个 `gost`
更新是不合理的，如果不是预期行为那么说明以前就有bug，这里需要修bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
