nanjiek commented on code in PR #3086:
URL: https://github.com/apache/dubbo-go/pull/3086#discussion_r2572864342
##########
protocol/triple/client.go:
##########
@@ -282,16 +312,18 @@ func newClientManager(url *common.URL) (*clientManager,
error) {
baseTriURL = httpPrefix + baseTriURL
}
- triClients := make(map[string]*tri.Client)
+ triClientPools := make(map[string]*TriClientPool)
if len(url.Methods) != 0 {
for _, method := range url.Methods {
triURL, err := joinPath(baseTriURL, url.Interface(),
method)
if err != nil {
- return nil, fmt.Errorf("JoinPath failed for
base %s, interface %s, method %s", baseTriURL, url.Interface(), method)
Review Comment:
I think you need to keep this.
##########
protocol/triple/client.go:
##########
@@ -307,16 +339,18 @@ func newClientManager(url *common.URL) (*clientManager,
error) {
methodName := serviceType.Method(i).Name
triURL, err := joinPath(baseTriURL, url.Interface(),
methodName)
if err != nil {
- return nil, fmt.Errorf("JoinPath failed for
base %s, interface %s, method %s", baseTriURL, url.Interface(), methodName)
Review Comment:
Same as the front.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
