Anshul-creator opened a new pull request, #15819: URL: https://github.com/apache/dubbo/pull/15819
## What is the purpose of the change? This PR stabilizes a large set of tests across three Spring-related test classes inside `dubbo-config-spring` that were intermittently failing under randomized execution orders (NonDex) due to shared Dubbo/Spring framework state leaking across test boundaries. The following tests were consistently among the flaky failures before this fix, but now pass reliably across all NonDex seeds: - **ConfigTest:** `testGenericServiceConfig`, `testSystemPropertyOverrideReferenceConfig`, `testServiceClass`, `testProviderNestedService`, `testSystemPropertyOverrideProtocol`, `test_noMethodInterface_methodsKeyHasValue`, `testInitReference`, `testDubboProtocolPortOverride`, `testAppendFilter`, `testSystemPropertyOverrideMultiProtocol`, `testMultiProtocol`, `testGenericServiceConfigThroughSpring` - **DubboNamespaceHandlerTest:** `testMetricsAggregation`, `testDelayFixedTime`, `testDefaultProtocol`, `testCustomParameter`, `testProviderXmlOnConfigurationClass`, `testProviderXml`, `testProperty`, `testNotificationWithWrongBean`, `testMonitor`, `testMultiProtocol`, `testTimeoutConfig`, `testModuleInfo` - **JavaConfigReferenceBeanTest:** `testGenericServiceAnnotationBean`, `testReferenceBean`, `testLazyProxy2`, `testAnnotationBean`, `testLazyProxy1`, `testGenericServiceReferenceBean`, `testAnnotationAtField`, `testLazyProxy3` ## Root Cause These failures are identical to previously fixed issues in: - https://github.com/apache/dubbo/pull/15778 - https://github.com/apache/dubbo/pull/15782 - https://github.com/apache/dubbo/pull/15785 Each of those PRs addressed flakiness caused by Micrometer’s `CompositeMeterRegistry`, which can throw an `ArrayIndexOutOfBoundsException` when it iterates over internal `IdentityHashMap` structures under randomized execution orders (NonDex). `ConfigTest`, `DubboNamespaceHandlerTest`, `JavaConfigReferenceBeanTest` suffered from the same underlying issue: Dubbo framework state was leaking between test methods. This meant that the behavior of reference creation in one test could affect subsequent tests, causing nondeterministic failures. ## Changes Made To fully isolate each test method and eliminate shared state, the following changes were applied: - Disabled the metrics subsystem at the beginning of each test. - Cleared all system properties via `SysProps.clear()` in the lifecycle hooks to avoid cross-test pollution. - Reset framework state using `DubboBootstrap.reset()` to ensure isolation between tests. - In `DubboNamespaceHandlerTest.testMetricsPrometheus()`, metrics are explicitly re-enabled in a controlled and isolated way to test Prometheus behavior without leaking state into other tests. ## Verification You can try running the following snippet of code from the dubbo repo root, on both pre-fix and post-fix code ```bash ./mvnw -q -pl dubbo-config/dubbo-config-spring \ edu.illinois:nondex-maven-plugin:2.2.1:nondex \ -DnondexRuns=50 ``` The tests should fail intermittently on the pre-fix version, but pass consistently across all seeds on the post-fix version. NonDex run logs will be available under the `dubbo-config/dubbo-config-spring/.nondex` directory. ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
