github-advanced-security[bot] commented on code in PR #827: URL: https://github.com/apache/dubbo-go-pixiu/pull/827#discussion_r2595633019
########## controllers/samples/backend.yaml: ########## @@ -0,0 +1,80 @@ +--- +apiVersion: v1 +kind: ServiceAccount +metadata: + name: backend + namespace: default +--- +apiVersion: v1 +kind: Service +metadata: + name: backend + namespace: default + labels: + app: backend + service: backend +spec: + ports: + - name: http + port: 3000 + targetPort: 3000 + selector: + app: backend +--- +apiVersion: apps/v1 +kind: Deployment +metadata: + name: backend + namespace: default +spec: + replicas: 1 + selector: + matchLabels: + app: backend + version: v1 + template: + metadata: + labels: + app: backend + version: v1 + spec: + serviceAccountName: backend + containers: + - image: gcr.io/k8s-staging-gateway-api/echo-basic:v20231214-v1.0.0-140-gf544a46e Review Comment: ## Memory limits should be enforced <!--SONAR_ISSUE_KEY:AZr1zF55fR9D5s-E1v0c-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&issues=AZr1zF55fR9D5s-E1v0c&open=AZr1zF55fR9D5s-E1v0c&pullRequest=827";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/dubbo-go-pixiu/security/code-scanning/264) ########## controllers/samples/backend.yaml: ########## @@ -0,0 +1,80 @@ +--- +apiVersion: v1 +kind: ServiceAccount +metadata: + name: backend + namespace: default +--- +apiVersion: v1 +kind: Service +metadata: + name: backend + namespace: default + labels: + app: backend + service: backend +spec: + ports: + - name: http + port: 3000 + targetPort: 3000 + selector: + app: backend +--- +apiVersion: apps/v1 +kind: Deployment +metadata: + name: backend + namespace: default +spec: + replicas: 1 + selector: + matchLabels: + app: backend + version: v1 + template: + metadata: + labels: + app: backend + version: v1 + spec: + serviceAccountName: backend Review Comment: ## Service account permissions should be restricted <!--SONAR_ISSUE_KEY:AZr1zF55fR9D5s-E1v0e-->Bind this Service Account to RBAC or disable "automountServiceAccountToken". <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&issues=AZr1zF55fR9D5s-E1v0e&open=AZr1zF55fR9D5s-E1v0e&pullRequest=827";>SonarQube Cloud</a></p> [Show more details](https://github.com/apache/dubbo-go-pixiu/security/code-scanning/265) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
