yumosx commented on code in PR #387:
URL: https://github.com/apache/dubbo-go-hessian2/pull/387#discussion_r2601684171
##########
map.go:
##########
@@ -276,7 +276,18 @@ func (d *Decoder) decMap(flag int32) (interface{}, error) {
d.appendRefs(instValue)
- for d.peekByte() != BC_END {
+ for {
Review Comment:
```
=== RUN TestMultipleLevelRecursiveDep2
hessian2 serialize 3.948985828s 10660KB
hessian2 deserialize 1.218173434s
decode_benchmark_test.go:75: deserialize too slow
--- FAIL: TestMultipleLevelRecursiveDep2 (11.67s)
```
##########
map.go:
##########
@@ -276,7 +276,18 @@ func (d *Decoder) decMap(flag int32) (interface{}, error) {
d.appendRefs(instValue)
- for d.peekByte() != BC_END {
+ for {
Review Comment:
@tiltwind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
