robocanic commented on code in PR #1366: URL: https://github.com/apache/dubbo-admin/pull/1366#discussion_r2637523783
########## pkg/core/lock/gorm_factory.go: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package lock + +import ( + "fmt" + + "gorm.io/gorm" + + "github.com/apache/dubbo-admin/pkg/core/logger" + "github.com/apache/dubbo-admin/pkg/core/runtime" +) + +func init() { + RegisterLockFactory(&gormLockFactory{}) +} + +type gormLockFactory struct{} + +// Support checks if a GORM Lock can be created from the context. +func (f *gormLockFactory) Support(ctx runtime.BuilderContext) bool { + storeComp, err := ctx.GetActivatedComponent(runtime.ResourceStore) + if err != nil { + return false + } + + type DataStoreProvider interface { + GetDataStore() any + } + + provider, ok := storeComp.(DataStoreProvider) Review Comment: Suggestion: The `ResourceStore` is designed for `Resource`, the usage here may not work correctly. How about distinguishing from the bottom layer, that is to say, using the store config to build a new connection pool just for lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
