Tsukikage7 opened a new pull request, #848:
URL: https://github.com/apache/dubbo-go-pixiu/pull/848
## feat(controllers): Improve gateway controller configuration and code
quality
### Summary
This PR addresses the review comments and technical debt from PR #827 and
#839, improving code
quality and configurability of the gateway controller.
### Changes
#### 1. Configurable Gateway Image and ImagePullPolicy
Previously hardcoded values are now configurable:
| Setting | Before | After (Default) |
|---------|--------|-----------------|
| Image | `mfordjody/pixiugateway:debug` | `apache/dubbo-go-pixiu:latest` |
| ImagePullPolicy | `Always` | `IfNotPresent` |
Configuration can be set via `GatewayConfig`:
```go
config.ControllerConfig.Gateway.Image = "custom/image:tag"
config.ControllerConfig.Gateway.ImagePullPolicy = "Always"
2. Add Warning Log for Unsupported Filter Types
Added logging in mergeFilterConfig default branch to help debug
configuration issues:
log.Printf("[WARN] mergeFilterConfig: unsupported filter type %q,
replacing config instead of
merging", filterType)
3. Refactor Duplicate Policy Loading Code
Merged duplicate implementations of LoadClusterPolicy and
LoadClusterPolicyByClusterName into
a shared private method loadClusterPolicyByName, reducing code duplication.
4. Add Unit Tests
New test coverage for:
- config.go: GatewayConfig, TimeDuration, LeaderElection
- utils_policy.go: splitClusterName edge cases
Related Issues
- Resolves review comments from PR #827
- Resolves review comments from PR #839 (@No-SilverBullet)
Test Plan
- All existing tests pass
- New unit tests pass (go test ./internal/controller/...)
- Build succeeds (go build ./...)
Checklist
- Code follows project style guidelines
- Added unit tests for new functionality
- No breaking changes to public APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
