1kasa commented on code in PR #3134:
URL: https://github.com/apache/dubbo-go/pull/3134#discussion_r2648897032
##########
protocol/triple/triple_protocol/triple_ext_test.go:
##########
@@ -1654,22 +1654,6 @@ func TestStreamForServer(t *testing.T) {
assert.NotNil(t, res)
assert.Equal(t, msg.Sum, int64(1))
})
- t.Run("client-stream-conn", func(t *testing.T) {
- t.Parallel()
- client, server := newPingServer(&pluggablePingServer{
- sum: func(ctx context.Context, stream
*triple.ClientStream) (*triple.Response, error) {
- assert.NotNil(t,
stream.Conn().Send("not-proto"))
- return
triple.NewResponse(&pingv1.SumResponse{}), nil
- },
- })
- t.Cleanup(server.Close)
- stream, err := client.Sum(context.Background())
- assert.Nil(t, err)
- assert.Nil(t, stream.Send(&pingv1.SumRequest{Number: 1}))
- res := triple.NewResponse(&pingv1.SumResponse{})
- err = stream.CloseAndReceive(res)
- assert.Nil(t, err)
- })
Review Comment:
I think this unit test is an important boundary test. Could you explain why
it was removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
