CuSO41108 opened a new pull request, #15934: URL: https://github.com/apache/dubbo/pull/15934
…acy getAttachment API ## What is the purpose of the change? This PR fixes the compatibility issue in `RpcContext` where non-String objects stored via `setObjectAttachment` could not be retrieved via the legacy `getAttachment(String)` method. ## Brief changelog - Modified `RpcContext#setObjectAttachment` to automatically store a String representation of the object for legacy API compatibility. - Addressed the TODO: "compatible with previous" in RpcContext.java. ## Verifying this change I have added a unit test `RpcContextCompatibilityTest` to verify that: 1. `getObjectAttachment` returns the original object (e.g., Long). 2. `getAttachment` returns the String representation (e.g., "12345") instead of null. I have already sent my ICLA to [email protected] ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
