Alanxtl commented on code in PR #854:
URL: https://github.com/apache/dubbo-go-pixiu/pull/854#discussion_r2654668594
##########
admin/web/tests/unit/example.spec.js:
##########
@@ -15,14 +15,11 @@
* limitations under the License.
*/
import { shallowMount } from '@vue/test-utils'
-import HelloWorld from '@/components/HelloWorld.vue'
+import EmptyTip from '@/components/EmptyTip.vue'
-describe('HelloWorld.vue', () => {
- it('renders props.msg when passed', () => {
- const msg = 'new message'
- const wrapper = shallowMount(HelloWorld, {
- propsData: { msg }
- })
- expect(wrapper.text()).toMatch(msg)
+describe('EmptyTip.vue', () => {
+ it('renders empty tip message', () => {
+ const wrapper = shallowMount(EmptyTip)
+ expect(wrapper.text()).toMatch('暂无数据')
Review Comment:
all use English
```suggestion
expect(wrapper.text()).toMatch('data not found')
```
##########
.github/workflows/pixiu-admin-ci.yml:
##########
@@ -201,20 +188,18 @@ jobs:
etcd:
image: quay.io/coreos/etcd:v3.6.1
env:
- ALLOW_NONE_AUTHENTICATION: yes
Review Comment:
Is it okay to remove this option?
##########
.github/workflows/pixiu-admin-ci.yml:
##########
@@ -289,7 +286,6 @@ jobs:
- name: Start etcd service
run: |
docker run -d -p 2379:2379 \
- --env ALLOW_NONE_AUTHENTICATION=yes \
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
