ShauryaChauhan1411 commented on code in PR #15962: URL: https://github.com/apache/dubbo/pull/15962#discussion_r2660481485
########## dubbo-remoting/dubbo-remoting-http12/src/test/java/org/apache/dubbo/remoting/http12/message/codec/YamlCodecTest.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.dubbo.remoting.http12.message.codec; + +import java.io.ByteArrayInputStream; +import java.io.InputStream; +import java.nio.charset.StandardCharsets; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertThrows; + +class YamlCodecTest { + + @Test + void testYamlSecurityVulnerability() { + String maliciousYaml = + "!!javax.script.ScriptEngineManager [ !!java.net.URLClassLoader [[ !!java.net.URL [\"http://127.0.0.1/\";] ]] ]"; + + InputStream is = new ByteArrayInputStream(maliciousYaml.getBytes(StandardCharsets.UTF_8)); + + assertThrows( + Exception.class, + () -> YamlCodec.INSTANCE.decode(is, Object.class, StandardCharsets.UTF_8), + "Security Hole: YamlCodec should have rejected the malicious class 'javax.script.ScriptEngineManager'"); + } + + @Test + void testRawSnakeYamlVulnerability() { + String maliciousYaml = + "!!javax.script.ScriptEngineManager [ !!java.net.URLClassLoader [[ !!java.net.URL [\"http://127.0.0.1/\";] ]] ]"; + + org.yaml.snakeyaml.Yaml rawYaml = new org.yaml.snakeyaml.Yaml(); + + assertThrows( Review Comment: Thank you for the feedback. I have updated both test cases to ensure they are not catching generic exceptions blindly. Since using the specific SerializationException class was causing classpath issues in my local environment, I have implemented message-based assertions using assertTrue(exception.getMessage().toLowerCase().contains("yaml")). This ensures the tests only pass if the error is specifically related to YAML security/parsing, preventing false positives from other exceptions as you pointed out. All local tests passed and I've applied the formatting using spotless:apply. Ready for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
