RainYuY commented on code in PR #15967:
URL: https://github.com/apache/dubbo/pull/15967#discussion_r2671272520
##########
dubbo-common/src/main/java/org/apache/dubbo/common/stream/CallStreamObserver.java:
##########
@@ -67,7 +100,7 @@ public interface CallStreamObserver<T> extends
StreamObserver<T> {
*
* @param onReadyHandler the handler to invoke when the stream becomes
ready
*/
- void setOnReadyHandler(Runnable onReadyHandler);
+ default void setOnReadyHandler(Runnable onReadyHandler) {}
Review Comment:
I think it’s a bit unusual that the default method in this interface is just
an empty implementation (it doesn’t perform any logic at all).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
