Copilot commented on code in PR #1017: URL: https://github.com/apache/dubbo-go-samples/pull/1017#discussion_r2679249327
########## registry/polaris/proto/greet.proto: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +syntax = "proto3"; + +package greet; + +option go_package = "github.com/apache/dubbo-go-samples/registry/polaris/proto;greet"; + +message GreetRequest { + string name = 1; +} + +message GreetResponse { + string greeting = 1; +} + +service GreetService { + rpc Greet(GreetRequest) returns (GreetResponse) {} +} + + Review Comment: Extra blank lines at the end of the file. For consistency with other proto files in the repository (e.g., registry/nacos/proto/greet.proto), remove these trailing blank lines. ```suggestion ``` ########## registry/polaris/README-zh.md: ########## @@ -0,0 +1,21 @@ +# 使用 Polaris 作为注册中心 + +本示例展示 dubbo-go 使用 Polaris 作为注册中心的服务发现功能。 + +## 如何运行 + +### 启动 Polaris 服务器 +按照[安装文档](https://polarismesh.cn/docs/%E4%BD%BF%E7%94%A8%E6%8C%87%E5%8D%97/%E6%9C%8D%E5%8A%A1%E7%AB%AF%E5%AE%89%E8%A3%85/%E5%8D%95%E6%9C%BA%E7%89%88%E5%AE%89%E8%A3%85/)安装并启动 Polaris 服务器。 + +### 运行服务端 +```shell +$ go run ./go-server/cmd/server.go +``` + +打开 Polaris 控制台，检查服务是否成功注册到 Polaris。 + +### 运行客户端 +```shell +$ go run ./go-client/cmd/client.go +``` + Review Comment: Extra blank line at the end of the file. For consistency, remove this trailing blank line. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
