CAICAIIs commented on code in PR #3170:
URL: https://github.com/apache/dubbo-go/pull/3170#discussion_r2703237558


##########
filter/generic/util.go:
##########
@@ -50,7 +50,9 @@ func isMakingAGenericCall(invoker base.Invoker, invocation 
base.Invocation) bool
 // isGeneric receives a generic field from url of invoker to determine whether 
the service is generic or not
 func isGeneric(generic string) bool {
        lowerGeneric := strings.ToLower(generic)
-       return lowerGeneric == constant.GenericSerializationDefault
+       return lowerGeneric == constant.GenericSerializationDefault ||
+               lowerGeneric == constant.GenericSerializationGson ||
+               lowerGeneric == constant.GenericSerializationProtobufJson

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to