AlexStocks commented on code in PR #3086:
URL: https://github.com/apache/dubbo-go/pull/3086#discussion_r2704421621


##########
protocol/triple/triple_protocol/client.go:
##########
@@ -36,7 +36,7 @@ type TimeoutKey struct{}
 // use the [WithTriple] options.
 type Client struct {
        config         *clientConfig
-       callUnary      func(context.Context, *Request, *Response) error
+       callUnary      func(context.Context, *Request, *Response, string) error

Review Comment:
   两个问题:
   1 string method 能否放进 Request?酱紫就可以不用添加参数了
   2 如果不能添加进 Request, string method 放在 Request 后面比较合适,不适宜放在最后。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to