LI123456mo commented on code in PR #16056:
URL: https://github.com/apache/dubbo/pull/16056#discussion_r2739904372
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyConnectionHandler.java:
##########
@@ -105,6 +105,7 @@ public void channelActive(ChannelHandlerContext ctx) {
@Override
public void channelInactive(ChannelHandlerContext ctx) throws Exception {
super.channelInactive(ctx);
+ // creates the pipeline
Review Comment:
Hi @heliang666s, sorry about that! I was studying the Netty transport logic
and accidentally left that comment in while I was taking notes on the code
flow. It doesn't add value to the PR, so I'll remove it. Thanks for catching
that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
