RainYuY commented on code in PR #16041:
URL: https://github.com/apache/dubbo/pull/16041#discussion_r2758725005
##########
dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/message/StreamingDecoder.java:
##########
@@ -59,6 +62,6 @@ private NoopFragmentListener() {}
public void bytesRead(int numBytes) {}
@Override
- public void onFragmentMessage(InputStream rawMessage) {}
+ public void onFragmentMessage(InputStream rawMessage, int
messageLength) {}
Review Comment:
Why do we need this message length parameter? Shouldn’t we just use the
stream’s available length instead? I think this approach would be better and
also avoid some security issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
