AlexStocks commented on code in PR #3185:
URL: https://github.com/apache/dubbo-go/pull/3185#discussion_r2762002991
##########
client/client_test.go:
##########
@@ -74,7 +74,7 @@ func TestGenerateInvocation(t *testing.T) {
resp := new(int)
opts := &CallOptions{RequestTimeout: "1s", Retries: "2"}
- inv, err := generateInvocation("Echo", []any{"foo", 1}, resp,
constant.CallUnary, opts)
+ inv, err := generateInvocation(context.Background(), "Echo",
[]any{"foo", 1}, resp, constant.CallUnary, opts)
Review Comment:
你这里也应该添加一个有 attachment 的 ut 吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
