Saramanda9988 commented on code in PR #3189: URL: https://github.com/apache/dubbo-go/pull/3189#discussion_r2767288313
########## metrics/rpc/error_classifier.go: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package rpc + +import ( + "dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol" +) + +// ErrorType represents the classification of RPC errors Review Comment: 感谢你的cr，在rpc等网络传输场景中使用iota确实存在风险，但这里的场景是内部统一处理多协议错误码，仅用于错误分类并路由到收集器，不涉及rpc，持久化以及序列化 对于这种内部分类逻辑，使用iota是完全安全的，这块我是否需要为了统一代码风格要求进行修改 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
