Copilot commented on code in PR #3197:
URL: https://github.com/apache/dubbo-go/pull/3197#discussion_r2776690328
##########
protocol/triple/reflection/serverreflection.go:
##########
@@ -278,9 +277,6 @@ func init() {
},
Priority: constant.DefaultPriority,
})
- // In order to adapt config.Load
- // Plans for future removal
- config.SetProviderServiceWithInfo(reflectionServer,
&rpb.ServerReflection_ServiceInfo)
}
Review Comment:
Removing the config.SetProviderServiceWithInfo call means this reflection
service is no longer registered in config's provider-service maps. In
config.Load mode, ProviderConfig.Load iterates config.GetProviderServiceMap(),
so this service can no longer be discovered/exported via configuration (even if
users define a ProviderConfig.Services entry for ReflectionServer), and
ServiceConfig.Export will also no longer be able to attach ServiceInfoKey from
config.GetProviderServiceInfo(). If config.Load is still a supported startup
path, please provide an alternative compatibility mechanism (e.g., export
internal services from server/internalProServices during config.Load startup,
or otherwise register this service+info without importing config here).
##########
protocol/triple/health/healthServer.go:
##########
@@ -186,9 +185,6 @@ func init() {
Priority: constant.DefaultPriority,
})
- // In order to adapt config.Load
- // Plans for future removal
- config.SetProviderServiceWithInfo(healthServer,
&triple_health.Health_ServiceInfo)
}
Review Comment:
Removing the config.SetProviderServiceWithInfo call means this health
service is no longer registered in config's provider-service maps. In
config.Load mode, ProviderConfig.Load iterates config.GetProviderServiceMap(),
so this service can no longer be discovered/exported via configuration (even if
users define a ProviderConfig.Services entry for HealthCheckServer), and
ServiceConfig.Export will also no longer be able to attach ServiceInfoKey from
config.GetProviderServiceInfo(). If config.Load is still a supported startup
path, please provide an alternative compatibility mechanism (e.g., export
internal services from server/internalProServices during config.Load startup,
or otherwise register this service+info without importing config here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
