AlexStocks commented on code in PR #1039:
URL: https://github.com/apache/dubbo-go-samples/pull/1039#discussion_r2825533204
##########
docker-compose.yml:
##########
@@ -1,52 +1,83 @@
# services config in one docker-compose file for integrate test
-# integrate test will start up services and samples test will depend on those
containers
services:
zookeeper:
- image: zookeeper:3.8.4
+ image: zookeeper:3.9.4
ports:
- "2181:2181"
- restart: on-failure
+ healthcheck:
+ test: ["CMD", "nc", "-z", "localhost", "2181"]
+ interval: 5s
+ timeout: 3s
+ retries: 10
+ start_period: 10s
+ restart: unless-stopped
+ networks: [itnet]
nacos:
- image: nacos/nacos-server:v2.1.2-slim
- container_name: nacos-standalone
+ image: nacos/nacos-server:v2.5.2
environment:
- - PREFER_HOST_MODE=hostname
- - MODE=standalone
+ PREFER_HOST_MODE: hostname
+ MODE: standalone
ports:
- - "8848:8848"
- - "9848:9848"
+ - "8848:8848"
+ - "9848:9848"
+ - "9849:9849"
healthcheck:
- test: "curl --fail
http://127.0.0.1:8848/nacos/v1/console/health/liveness || exit 1"
+ test: [ "CMD", "curl", "-f", "http://localhost:8848/nacos/"; ]
Review Comment:
确定 liveness check 可以吧 v1/console/health/liveness 去掉吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
