DocJlm commented on PR #16097: URL: https://github.com/apache/dubbo/pull/16097#issuecomment-3942083052
> Hi @DocJlm , I think the code is already implementing the "StringBuffer"? Hi @LI123456mo, yes, you're right. I initially changed `StringBuffer` to `StringBuilder` in `replaceProperty()`, but the CI build failed because `Matcher.appendReplacement()` and `Matcher.appendTail()` only accept `StringBuffer` in Java 8 (the `StringBuilder` overload was added in Java 9).Since Dubbo needs to maintain Java 8 compatibility, I reverted that change. The remaining changes in this PR focus on fixing resource leaks using try-with-resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
