mike-lmctl opened a new pull request, #16258: URL: https://github.com/apache/dubbo/pull/16258
## What is the purpose of the change? GitHub_issue: #12961 This fixes binding for named protocol properties like `dubbo.protocols.rest.default=false`. The `default` getter still stays out of URL attributes, but config refresh now allows that property to be assigned. That keeps a named protocol marked as non-default from being returned by `getDefaultProtocols()`. I added a regression test for a named protocol with `default=false`, including a check that `default` is still not appended as a URL parameter. Tested: ```text ./mvnw -pl dubbo-config/dubbo-config-api -am -Dtest=ProtocolConfigTest#testCreateNonDefaultConfigFromPropsWithName -Dsurefire.failIfNoSpecifiedTests=false test ./mvnw -pl dubbo-config/dubbo-config-api -am -Dtest=ProtocolConfigTest -Dsurefire.failIfNoSpecifiedTests=false test ``` ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
