CAICAIIs commented on code in PR #3320:
URL: https://github.com/apache/dubbo-go/pull/3320#discussion_r3214401708
##########
options.go:
##########
@@ -166,8 +165,6 @@ func (rc *InstanceOptions) init(opts ...InstanceOption)
error {
return err
}
- compatInstanceOptions(rcCompat, rc) // overrider options config because
some config are changed after init
Review Comment:
是的，以前这里最后一次 overwrite 实际上会让初始化后的 legacy config.RootConfig 成为最终来源，让初始化后的旧
config 反过来覆盖 global
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
