Alanxtl commented on issue #3322: URL: https://github.com/apache/dubbo-go/issues/3322#issuecomment-4436932148
> [@Alanxtl](https://github.com/Alanxtl) Hello，这边看了下代码，目前代码里有用到viper的主要是tools/dubbogo-cli和Apollo的测试代码里： > > 1. dubbogo-cli 里原来通过 viper 尝试读取 CLI 自己的配置文件，但实际代码里没有使用 viper.Get*、Unmarshal、BindPFlag 等读取配置值的逻辑，只是在成功读取配置文件后打印 Using configfile: ...，对实际流程没有影响，而且已经被标记为deprecated了。**这里可以替换为koanf，但这段代码实际没有用处，可否考虑直接删除？** > 2. config_center/apollo/impl_test.go这个测试会用到viper进行解析，向上层返回map。**这里直接替换成koanf应该也可以。** There is no need to update dubbogo-cli as it has indeed been deprecated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
