CAICAIIs opened a new pull request, #3326: URL: https://github.com/apache/dubbo-go/pull/3326
## What Continue #3204 by removing the legacy `config.GetConsumerConfig()` timeout fallback from protocol invokers. This PR updates: - `protocol/dubbo` - `protocol/jsonrpc` Both now read request timeout in this order: 1. URL `timeout` param 2. URL `ConsumerConfigKey` attribute 3. `global.DefaultConsumerConfig().RequestTimeout` ## Why After #3320, `global / InstanceOptions` should be the runtime source of truth, and `config.RootConfig` should only remain as a legacy mirror/input adapter. These two protocol packages only used `config.GetConsumerConfig().RequestTimeout` as a fallback. Using `global.DefaultConsumerConfig()` keeps the same default value (`3s`) while removing the direct runtime dependency on `config`. ## Tests - `go test ./protocol/dubbo ./protocol/jsonrpc -run 'TestNewDubboInvokerUses|TestJsonrpcProtocolRefer' -count=1` - `go test ./protocol/dubbo ./protocol/jsonrpc -count=1` - `go test ./...` ### Checklist - [x] I confirm the target branch is `develop` - [x] Code has passed local testing - [x] I have added tests that prove my fix is effective or that my feature works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
