Alanxtl commented on code in PR #3357:
URL: https://github.com/apache/dubbo-go/pull/3357#discussion_r3329742018
##########
metadata/info/metadata_info.go:
##########
@@ -124,6 +125,13 @@ func removeUrl(m map[string][]*common.URL, url
*common.URL) {
}
}
+func urlEqual(left, right *common.URL) bool {
+ if left == nil || right == nil {
+ return left == right
+ }
+ return left.String() == right.String() && slices.Equal(left.Methods,
right.Methods)
+}
Review Comment:
不要抽象一个函数 没必要
你可以用common/url里面有一个
func (c *URL) URLEqual(url *URL) bool {
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
