leno23 commented on PR #3328: URL: https://github.com/apache/dubbo-go/pull/3328#issuecomment-4646061003
Addressed the CI failure in commit 4e3dc2f. The failing consistent hashing test still expected the old trailing-question-mark form, so I updated it to match the new URL.String() behavior. Before this PR, URL.String() for dubbo://127.0.0.1:20000/com.test.Service returned: dubbo://127.0.0.1:20000/com.test.Service? After this PR, it returns: dubbo://127.0.0.1:20000/com.test.Service Local targeted validation passed with the available Go toolchain: - GOTOOLCHAIN=local go test -timeout=60s ./cluster/loadbalance/consistenthashing -run TestConsistentHashSelectorSuite/TestSelectForKey - GOTOOLCHAIN=local go test -timeout=60s ./common -run "TestURLStringWithoutQuery|TestURL" The CI command requested Go 1.25, but downloading that toolchain stalled locally, so I used the local Go toolchain for targeted verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
