Alanxtl commented on PR #3371: URL: https://github.com/apache/dubbo-go/pull/3371#issuecomment-4655867589
1. 当前测试覆盖率偏低，建议至少补一两个 timer/GC 核心分支测试，尤其是 stale revision 被清理、alive revision 被保留这两个路径。 2. doRenewAppMetadata 里依赖 MetadataInfo.Snapshot()，合并 #3367 后要确认 Snapshot 是带锁/深拷贝语义，避免 renew 时读写 metadata 产生 race -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
