chensishang commented on code in PR #16299:
URL: https://github.com/apache/dubbo/pull/16299#discussion_r3401466735
##########
dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java:
##########
@@ -290,6 +290,14 @@ Invoker<?> getInvoker(Channel channel, Invocation inv)
throws RemotingException
boolean isStubServiceInvoke;
int port = channel.getLocalAddress().getPort();
String path = (String) inv.getObjectAttachmentWithoutConvert(PATH_KEY);
+ if (path == null) {
+ throw new RemotingException(
Review Comment:
Thanks for the careful review — you're right, and I appreciate you pointing
this out. A null path indicates missing or corrupted invocation metadata in
general, and my original message attributing ▎ it solely to non-serializable
parameters could indeed cause another misleading diagnosis
I've updated the message to describe the problem generically and only
mention deserialization failure as one of several possible causes (along with
protocol incompatibility and custom
codec/invocation implementations). Please let me know if the wording
could be further improved — happy to adjust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
