leno23 commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4701575432
Thanks, I agree with the direction. I checked the current dependency versions: `github.com/apache/dubbo-go-hessian2 v1.13.1` still has `NewDubboGenericException` only populate `ExceptionClass` / `ExceptionMessage`, so removing `newGenericException` here now would make `Error()` return an empty `DetailMessage` and break the behavior covered by these tests. The constructor-side fix is still in apache/dubbo-go-hessian2#396 and is not available from an upstream module version yet. Once that hessian2 PR is merged and available to dubbo-go, I can update the dependency here and replace `newGenericException` with the constructor directly to avoid maintaining the formatting in both places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
