Alanxtl commented on PR #3428: URL: https://github.com/apache/dubbo-go/pull/3428#issuecomment-4715244038
This looks like a reasonable compromise to me. Since these APIs expose `http.Header`, storing context headers in canonical form makes standard `Header.Get/Values` work as users would expect. At the same time, converting keys back to lowercase when merging into `Invocation` attachments keeps the Dubbo/gRPC metadata semantics aligned with grpc-go, dubbo-java, and HTTP/2 wire behavior. Could we add a short comment around the `CanonicalHeaderKey` / `ToLower` boundary to make this intentional layering explicit? Something like: context headers use canonical `http.Header` keys for Go API compatibility, while invocation attachments remain lowercase metadata keys for Dubbo/gRPC compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
