Copilot commented on code in PR #979:
URL: https://github.com/apache/dubbo-go-pixiu/pull/979#discussion_r3418558235
##########
go.mod:
##########
@@ -154,6 +154,7 @@ require (
github.com/gobwas/glob v0.2.3 // indirect
github.com/goccy/go-json v0.10.3 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
+ github.com/golang/mock v1.6.0 // indirect
Review Comment:
The module now depends on both `go.uber.org/mock` and
`github.com/golang/mock` (indirect). If the codebase has fully migrated, it’s
better to avoid keeping the old module around to reduce confusion and prevent
tooling drift. Consider running `go mod tidy` and removing the explicit
indirect `github.com/golang/mock` entry if it’s no longer required by any
dependency/tooling; if it is still required (e.g., for `mockgen` tooling),
consider documenting that in the repo’s tooling/setup to make the
dual-dependency intentional.
##########
pkg/server/controls/mocks/mocks.go:
##########
@@ -22,7 +22,7 @@ import (
)
import (
- gomock "github.com/golang/mock/gomock"
+ gomock "go.uber.org/mock/gomock"
Review Comment:
If this file is generated by `mockgen` (the path `.../mocks/mocks.go`
suggests it may be), changing the import manually can be overwritten the next
time mocks are regenerated. Consider updating any `go:generate` directives /
build scripts to use the compatible generator (`go.uber.org/mock/mockgen`) so
regeneration consistently produces the Uber import path.
##########
go.mod:
##########
@@ -61,6 +60,7 @@ require (
go.opentelemetry.io/otel/sdk v1.43.0
go.opentelemetry.io/otel/sdk/metric v1.43.0
go.opentelemetry.io/otel/trace v1.43.0
+ go.uber.org/mock v0.5.2
Review Comment:
The module now depends on both `go.uber.org/mock` and
`github.com/golang/mock` (indirect). If the codebase has fully migrated, it’s
better to avoid keeping the old module around to reduce confusion and prevent
tooling drift. Consider running `go mod tidy` and removing the explicit
indirect `github.com/golang/mock` entry if it’s no longer required by any
dependency/tooling; if it is still required (e.g., for `mockgen` tooling),
consider documenting that in the repo’s tooling/setup to make the
dual-dependency intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
