Aias00 commented on PR #981: URL: https://github.com/apache/dubbo-go-pixiu/pull/981#issuecomment-4716209914
Replying to @Copilot's review comment on `go.mod`: Thanks for the review! This is actually a false positive — `github.com/mitchellh/mapstructure v1.5.0` is already present in `go.mod` (line 37) as a direct dependency, used by 6 other files in the codebase (`pkg/model/http.go`, `pkg/model/listener.go`, `pkg/config/xds/xds.go`, `pkg/tracing/jaeger/jaeger.go`, `pkg/cluster/retry/exponentialbackoff/exponential_back_off.go`, `pkg/wasm/service.go`). We only replaced the import path in `config_load.go` from the obsolete fork to the existing standard package, so no new dependency entry is needed. `go mod tidy`, `go build ./...`, and `go test ./pkg/config/...` all pass cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
