Aias00 opened a new pull request, #984:
URL: https://github.com/apache/dubbo-go-pixiu/pull/984
## Summary
Remove the personal-domain dependency `v.marlon.life/toolkit` and replace it
with the standard library `sync.WaitGroup`.
## Problem
`v.marlon.life/toolkit v0.0.0-20211025131614-e4a91730b4ab` is a dependency
from a personal domain with no stability guarantees:
- **Domain/repository stability**: personal domains can expire, repos can be
deleted
- **Apache compliance**: personal non-versioned dependencies may not satisfy
IP clarity requirements
- **Minimal usage**: only `util.WaitGroupWrapper` is used, which is a
trivial wrapper around `sync.WaitGroup`
## Changes
| File | Change |
|------|--------|
| `admin/core/server.go` | Replace `util.WaitGroupWrapper` with
`sync.WaitGroup`; `AddAndRun(fn)` → `wg.Add(1)` + `go func(){ defer wg.Done();
fn() }()` |
| `go.mod` | Remove `v.marlon.life/toolkit` dependency |
| `go.sum` | Remove `v.marlon.life/toolkit` checksum entries |
## Verification
- `go vet ./admin/core/...` — pass
- `go build ./admin/core/` — pass
- `go mod tidy` — no changes (clean)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
