mochengqian commented on PR #1477:
URL: https://github.com/apache/dubbo-admin/pull/1477#issuecomment-4737334214
Thanks for the detailed review. I handled the blocking parts and refreshed
the PR description to match the implemented scope.
- Blocker 1: updated the PR title/body so rollback is explicitly in scope.
The description now states that rollback is append-only re-publish via
ResourceManager and creates a new immutable `RuleVersion` with
`source=ROLLBACK` and `rolledBackFromId=<targetVersionId>`. The old
rollback-out-of-scope wording is gone.
- Blocker 2: pushed `cabe2eb` to make rollback actively call `RepairIntent`
after `ResourceManager.Upsert` before falling back to the final
committed-version observation. This avoids returning a 500 in the case where
the rule write succeeded but the version commit was not immediately observed. I
also added `TestRollbackRuleVersion_RepairsWhenCommitNotObserved`, which mutes
the versioning subscriber event during rollback and verifies the API still
returns `committed=true` with a repaired `source=ROLLBACK` version.
- Major 2: rechecked the PR checks after the new push. Current GitHub checks
are green: Go 1.23, Go 1.24, License Check, SonarCloud, and SonarCloud Code
Analysis all pass.
Local validation run:
```bash
go test ./pkg/console/service -run RollbackRuleVersion
go test ./pkg/console/service/...
go test ./pkg/core/versioning/... \
./pkg/config/versioning/... \
./pkg/config/app/... \
./pkg/console/handler/... \
./pkg/console/service/...
git diff --check
```
I also ran `cd ui-vue3 && npm run type-check`; it still fails on existing
repo-wide TS issues such as missing `js-cookie` / `js-yaml` declarations,
`TAB_STATE` typed as `unknown`, and older routing/tag/dynamic-config model
typing errors. Those failures are not introduced by this backend rollback
consistency fix, and the GitHub PR workflow's frontend build step is passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
